Impact
Git uses external "credential helper" programs to store and retrieve passwords or other credentials from secure storage provided by the operating system. Specially-crafted URLs that contain an encoded newline can inject unintended values into the credential helper protocol stream, causing the credential helper to retrieve the password for one server (e.g., good.example.com) for an HTTP request being made to another server (e.g., evil.example.com), resulting in credentials for the former being sent to the latter. There are no restrictions on the relationship between the two, meaning that an attacker can craft a URL that will present stored credentials for any host to a host of their choosing.
The vulnerability can be triggered by feeding a malicious URL to git clone. However, the affected URLs look rather suspicious; the likely vector would be through systems which automatically clone URLs not visible to the user, such as Git submodules, or package systems built around Git.
Patches
The problem has been patched in the versions published on April 14th, 2020, going back to v2.17.x. Anyone wishing to backport the change further can do so by applying commit 9a6bbee (the full release includes extra checks for git fsck, but that commit is sufficient to protect clients against the vulnerability).
Workarounds
The most complete workaround is to disable credential helpers altogether:
git config --unset credential.helper
git config --global --unset credential.helper
git config --system --unset credential.helper
An alternative is to avoid malicious URLs:
-
examine the hostname and username portion of URLs fed to git clone for the presence of encoded newlines (%0a) or evidence of credential-protocol injections (e.g., host=github.com)
-
avoid using submodules with untrusted repositories (don't use clone --recurse-submodules; use git submodule update only after examining the URLs found in .gitmodules)
-
avoid tools which may run git clone on untrusted URLs under the hood
Credits
This vulnerability was found by Felix Wilhelm of Google Project Zero and fixed by Jeff King of GitHub.
References
felixwilhelm Analyst
peff Analyst
Impact
Git uses external "credential helper" programs to store and retrieve passwords or other credentials from secure storage provided by the operating system. Specially-crafted URLs that contain an encoded newline can inject unintended values into the credential helper protocol stream, causing the credential helper to retrieve the password for one server (e.g.,
good.example.com) for an HTTP request being made to another server (e.g.,evil.example.com), resulting in credentials for the former being sent to the latter. There are no restrictions on the relationship between the two, meaning that an attacker can craft a URL that will present stored credentials for any host to a host of their choosing.The vulnerability can be triggered by feeding a malicious URL to
git clone. However, the affected URLs look rather suspicious; the likely vector would be through systems which automatically clone URLs not visible to the user, such as Git submodules, or package systems built around Git.Patches
The problem has been patched in the versions published on April 14th, 2020, going back to v2.17.x. Anyone wishing to backport the change further can do so by applying commit 9a6bbee (the full release includes extra checks for
git fsck, but that commit is sufficient to protect clients against the vulnerability).Workarounds
The most complete workaround is to disable credential helpers altogether:
An alternative is to avoid malicious URLs:
examine the hostname and username portion of URLs fed to
git clonefor the presence of encoded newlines (%0a) or evidence of credential-protocol injections (e.g.,host=github.com)avoid using submodules with untrusted repositories (don't use
clone --recurse-submodules; usegit submodule updateonly after examining the URLs found in.gitmodules)avoid tools which may run
git cloneon untrusted URLs under the hoodCredits
This vulnerability was found by Felix Wilhelm of Google Project Zero and fixed by Jeff King of GitHub.
References